armin/linspector
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

The logger is still not multiprocess capable! This needs to be fixed.

Browse source 
I added comments with more information.
This commit is contained in:
Johannes Findeisen 2022-10-11 05:25:17 +02:00
commit 48a3e5e88f
3 changed files with 8 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

2
bin/linspector
View file

@ -33,7 +33,7 @@ from linspector.core.monitors import Monitors
# i currently only increase the 3rd number because the goal is that 0.19.* will become the first # i currently only increase the 3rd number because the goal is that 0.19.* will become the first
# stable version. # stable version.
__version__ = '0.19.56.dev1' __version__ = '0.19.57.dev1'
__author__ = 'Johannes Findeisen <you@hanez.org>' __author__ = 'Johannes Findeisen <you@hanez.org>'

2
etc/linspector.conf
View file

@ -7,7 +7,7 @@ log_level= debug
log_file = ~/code/linspector/linspector/log/linspector.log log_file = ~/code/linspector/linspector/log/linspector.log
; number of log files to be kept. i recommend to use the lowest sensible value for keeping performance high. so set ; number of log files to be kept. i recommend to use the lowest sensible value for keeping performance high. so set
; the size of the log file higher to increase the log history. ; the size of the log file higher to increase the log history.
log_file_count = 10 log_file_count = 20
; log file size in megabytes as int. the default is 10000000 bytes (10MiB) set in the code if not configured here. ; log file size in megabytes as int. the default is 10000000 bytes (10MiB) set in the code if not configured here.
log_file_size = 1 log_file_size = 1
; log file size in bytes as int. you can set to bytes if you want to set a value lower then 1 megabyte. but it will ; log file size in bytes as int. you can set to bytes if you want to set a value lower then 1 megabyte. but it will

6
linspector/core/logger.py
View file

@ -13,6 +13,11 @@ from logging import handlers
logger = getLogger('linspector') logger = getLogger('linspector')
# wow, this is not process capable! i thought in a last commit that the problem ist fixed, but it
# isn't!!! see here for more details:
# https://docs.python.org/3/howto/logging-cookbook.html#logging-to-a-single-file-from-multiple-processes
# a different approach on handling this can be to use a exclusive log file for each process but
# this is not what i want.
# maybe subclass it from logging.Logger...? # maybe subclass it from logging.Logger...?
class Log: class Log:
def __init__(self, configuration, stdout, verbose): def __init__(self, configuration, stdout, verbose):
@ -102,6 +107,7 @@ class Log:
import inspect import inspect
import multiprocessing import multiprocessing
import threading import threading
# https://www.geeksforgeeks.org/how-to-get-the-process-id-from-python-multiprocess/
current_process = multiprocessing.current_process() current_process = multiprocessing.current_process()
from_stack = inspect.stack()[1] from_stack = inspect.stack()[1]
function_name = from_stack.function function_name = from_stack.function