zynk/irssi
2
0
Fork 0
mirror of https://github.com/irssi/irssi.git synced 2026-08-09 11:50:10 +02:00
Code Issues Projects Releases Packages Wiki Activity

Fix debug output target: Send to current window not status

Browse source 
Problem: Debug printtext(NULL, NULL, ...) was sending debug messages
to status window, which caused crashes when status window tried to
format timestamps for debug messages.

Root cause: Status window environment/context different from chat windows,
causing crashes in expando_time() -> getenv() during timestamp formatting.

Solution: Use printtext_window() to send debug to current dest->window
or active_win instead of status window.

This prevents crashes when debugging nick formatting while focus is
on status window or when sending debug to inappropriate window contexts.

Timestamp: 2025-01-25 02:32
This commit is contained in:
kofany 2025-08-25 02:33:00 +02:00
commit 5a8392f9d8
1 changed files with 12 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

22
src/fe-common/core/formats.c
View file

@ -45,6 +45,9 @@ static const char *ext_color_al = "0123456789ABCDEFGHIJKLMNOPQRSTUVWXYZ";
static int signal_gui_print_text;
static int hide_text_style, hide_server_tags, hide_colors;
/* Global recursion protection for nick column formatting */
static int nick_formatting_depth = 0;
static int timestamp_level;
static int timestamp_timeout;
@ -909,26 +912,25 @@ char *format_get_text_theme_charargs(THEME_REC *theme, const char *module,
/* Apply nick column formatting if enabled and this is a message format */
/* Additional protection: avoid recursion during timestamp formatting */
{
static int formatting_depth = 0;
if (settings_get_bool("nick_column_enabled") &&
g_strcmp0(module, "fe-common/core") == 0 &&
is_message_format(formatnum) &&
formatting_depth == 0) { /* Prevent recursion */
nick_formatting_depth == 0) { /* Prevent recursion */
formatting_depth++;
nick_formatting_depth++;
modified_text = apply_nick_column_formatting(text, formatnum);
text = modified_text;
formatting_depth--;
nick_formatting_depth--;
/* Debug output - use printf to avoid recursion */
/* Debug output - send to current window, not status */
if (settings_get_bool("debug_nick_column")) {
printf("DEBUG format_auto: formatnum=%d, original='%s'\n", formatnum, module_theme->expanded_formats[formatnum]);
printf("DEBUG format_auto: modified='%s'\n", text);
WINDOW_REC *window = dest && dest->window ? dest->window : active_win;
printtext_window(window, MSGLEVEL_CLIENTCRAP,
"DEBUG format_auto: formatnum=%d, original='%s'", formatnum, module_theme->expanded_formats[formatnum]);
printtext_window(window, MSGLEVEL_CLIENTCRAP,
"DEBUG format_auto: modified='%s'", text);
}
}
}
result = format_get_text_args(dest, text, args);