zynk/irssi
2
0
Fork 0
mirror of https://github.com/irssi/irssi.git synced 2026-08-10 12:23:37 +02:00
Code Issues Projects Releases Packages Wiki Activity

Use-after-frees

Browse source 
Hi folks!

I tried clang-static-analyzer on irssi 1.1.1, it seems like it
finds some things. Here's a diff, but there might be more that you would
want to check, or choose to work differently.

(in special-vars.c, ret is commands->data sometime)

I hope it's not too much trouble if reported as a confidential bug.
Thanks.
This commit is contained in:
coypu@sdf.org 2018-08-11 22:28:14 +00:00 • committed by ailin-nemui
commit 610ab2dafa
5 changed files with 8 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

3
src/fe-common/core/themes.c
View file

@ -1424,8 +1424,9 @@ void themes_reload(void)
change_theme(settings_get_str("theme"), FALSE);
while (refs != NULL) {
theme_unref(refs->data);
gconstpointer tmp = refs->data;
refs = g_slist_remove(refs, refs->data);
theme_unref(tmp);
}
}