zynk/irssi
2
0
Fork 0
mirror of https://github.com/irssi/irssi.git synced 2026-08-08 19:30:15 +02:00
Code Issues Projects Releases Packages Wiki Activity

dcc: enforce declared receive size

Browse source 
DCC GET trusts the sender-provided size for UI and auto-get policy but continues writing until the peer closes the connection. A sender can advertise a small file and exhaust the receiver filesystem.

Limit each read to the remaining declared byte count and close the transfer once that count has been reached.
This commit is contained in:
Acts1631 2026-07-09 17:13:04 -04:00 • committed by Acts1631
commit 880da53aad
1 changed files with 11 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

13
src/irc/dcc/dcc-get.c
View file

@ -150,15 +150,24 @@ static void sig_dccget_send(GET_DCC_REC *dcc)
/* input function: DCC GET received data */
static void sig_dccget_receive(GET_DCC_REC *dcc)
{
int ret;
uoff_t remaining;
int ret, read_size;
if (dcc_get_recv_buffer == NULL) {
dcc_get_recv_buffer = g_malloc(DCC_GET_RECV_BUFFER_SIZE);
}
for (;;) {
if (dcc->transfd >= dcc->size) {
dcc_close(DCC(dcc));
return;
}
remaining = dcc->size - dcc->transfd;
read_size = remaining > DCC_GET_RECV_BUFFER_SIZE ?
DCC_GET_RECV_BUFFER_SIZE : (int) remaining;
ret = net_receive(dcc->handle, dcc_get_recv_buffer,
DCC_GET_RECV_BUFFER_SIZE);
read_size);
if (ret == 0) break;
if (ret < 0) {