zynk/irssi
2
0
Fork 0
mirror of https://github.com/irssi/irssi.git synced 2026-08-09 03:40:16 +02:00
Code Issues Projects Releases Packages Wiki Activity

irc-nicklist: initialize nickrec->hops when sscanf fails in fill_who

Browse source 
When fill_who() is called from event_whox_channel_full, the hops
parameter may be an empty string if the server sent a malformed WHOX
reply with fewer tokens than expected. sscanf() on an empty string
returns 0 (no items matched), leaving nickrec->hops at its prior
value rather than a clean default.

Fix: check the sscanf return value and set hops to 0 if parsing
failed.
This commit is contained in:
Devon Kirk 2026-07-01 17:18:15 -04:00
commit c02337a150
1 changed files with 2 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

3
src/irc/core/irc-nicklist.c
View file

@ -245,7 +245,8 @@ static void fill_who(SERVER_REC *server, const char *channel, const char *user,
nicklist_set_account(chanrec, nickrec,
strcmp(account, "0") == 0 ? "*" : account);
}
sscanf(hops, "%d", &nickrec->hops);
if (sscanf(hops, "%d", &nickrec->hops) != 1)
nickrec->hops = 0;
}
nicklist_update_flags(server, nick,